Differential D791
Create Scheduler API Authored by sashank on Aug 9 2019, 10:18 PM.
Details
Scheduler API: Scheduler is an abstract class which defines methods such as create_schedule, start_schedule, etc. Each instance of a Scheduler stores a list of RunSchedules Two implementations of Scheduler included are:
unit
Diff Detail
Event TimelineComment Actions
Happy to sit and do a high level API design chat if you want. The GraphQL schema change is usually a good framing for making sure things feel right.
Comment Actions Scheduler API: There is an abstract base class Scheduler, which defines abstract methods such as create_schedule, start_schedule, etc. There are two scheduler classes that implement Scheduler:
Each scheduler stores a list of Schedules. The type of the schedules depends on the type of the scheduler. TestScheduler simply uses the base Schedule class, but SystemCronScheduler uses SystemCronSchedule, which implements the logic for reading the schedule to and from the file. Comment Actions this feels worth putting in its own directory /dagster_graphql/implementation/scheduler/ maybe or just /dagster_graphql/scheduler/, might be time to move away from the catch all implementation folder.
Comment Actions Moved code to /implementation/scheduler/ and deleted SystemCronSchedule (logic moved to SystemCronScheduler) Comment Actions seems like a good start. will let @alangenfeld do final approval as you two have been discussing
Comment Actions
Comment Actions Use keys instead of attributes to access execution_params dict in all_schedules_for_pipeline
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
