Differential D7903

Load new image into existing kind cluster
ClosedPublic
Actions

Authored by • johann on May 13 2021, 8:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 16, 11:41 AM

	Unknown Object (File)
	Wed, Sep 14, 10:48 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

	Unknown Object (File)
	Tue, Sep 13, 8:53 AM

View All 36 Files

Subscribers

None

Details

Reviewers

• dgibson
• jordansanders

Commits

R1:6055f457ab34: Load new image into existing kind cluster

Summary

When iterating on kind tests locally, it's much faster to reuse the same kind cluster. This change supports that workflow by loading in new images when the integration image has changed. If it hasn't changed, kind recognizes by the hash and skips loading it itself.

Test Plan

local integration

Diff Detail

Repository

Branch

refactor-step-handler (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• johann created this revision.May 13 2021, 8:26 PM

• johann edited the summary of this revision. (Show Details)May 13 2021, 8:28 PM

• johann added reviewers: • dgibson, • jordansanders.

Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2021, 8:45 PM

Harbormaster failed remote builds in B30537: Diff 37539!

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2021, 9:11 PM

Harbormaster failed remote builds in B30543: Diff 37546!

up

Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2021, 9:33 PM

Harbormaster failed remote builds in B30551: Diff 37557!

up

Harbormaster completed remote builds in B30557: Diff 37564.May 13 2021, 10:33 PM

• johann requested review of this revision.May 13 2021, 10:33 PM

• dgibson accepted this revision.May 14 2021, 2:18 AM

This revision is now accepted and ready to land.May 14 2021, 2:18 AM

Closed by commit R1:6055f457ab34: Load new image into existing kind cluster (authored by • johann). · Explain WhyMay 18 2021, 3:11 PM

This revision was automatically updated to reflect the committed changes.

• johann added a commit: R1:6055f457ab34: Load new image into existing kind cluster.

Revision Contents
Changeset List

Path

Size

integration_tests/

python_modules/

dagster-k8s-test-infra/

dagster_k8s_test_infra/

6 lines

Diff 37546

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/cluster.py

Loading...