Page MenuHomeElementl
Differential D7897

[dagit] Use Yarn v2
ClosedPublic
Actions

Authored by dish on May 13 2021, 5:53 PM.

Details

Reviewers
bengotow
Commits
R1:07f9bfa7f5f0: [dagit] Use Yarn v2
Summary

Migrate to Yarn v2.

https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern

Test Plan

Build and run Dagit locally. Jest, lint, ts.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.May 13 2021, 5:53 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 13 2021, 6:16 PM
Harbormaster failed remote builds in B30521: Diff 37520!
dish updated this revision to Diff 37523.May 13 2021, 6:26 PM

Update tox.ini

Harbormaster completed remote builds in B30524: Diff 37523.May 13 2021, 6:47 PM
dish requested review of this revision.May 13 2021, 6:47 PM
bengotow accepted this revision.May 14 2021, 9:47 PM

Looks good to me and patches ok! Excited to give this a spin for a bit and see what else they've improved 🙌

js_modules/dagit/.yarnrc.yml
63

Wow hadn't seen this before and just googled it, this is a super cool feature

This revision is now accepted and ready to land.May 14 2021, 9:47 PM
Closed by commit R1:07f9bfa7f5f0: [dagit] Use Yarn v2 (authored by dish). · Explain WhyMay 17 2021, 2:39 PM
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:07f9bfa7f5f0: [dagit] Use Yarn v2.

Revision Contents
Changeset List

PathSize
2 lines
js_modules/
dagit/
2 lines
8 lines
.yarn/
plugins/
@yarnpkg/
8 lines
releases/
147392 lines
55 lines
1 line
65 lines
12 lines
packages/
app/
11 lines
core/
.storybook/
1 line
27 lines
src/
pipelines/
2 lines
runs/
4 lines
2 lines
44285 lines

Diff 37654

View Options

.arclint

Loading...
View Options

js_modules/dagit/.gitattributes

Loading...
View Options

js_modules/dagit/.gitignore

Loading...
View Options

js_modules/dagit/.yarn/plugins/@yarnpkg/plugin-typescript.cjs

Loading...
View Options

js_modules/dagit/.yarn/releases/yarn-1.22.10.cjs

Loading...
View Options

js_modules/dagit/.yarn/releases/yarn-berry.cjs

Loading...
View Options

js_modules/dagit/.yarnrc

Loading...
View Options

js_modules/dagit/.yarnrc.yml

Loading...
View Options

js_modules/dagit/package.json

Loading...
View Options

js_modules/dagit/packages/app/package.json

Loading...
View Options

js_modules/dagit/packages/core/.storybook/main.js

Loading...
View Options

js_modules/dagit/packages/core/package.json

Loading...
View Options

js_modules/dagit/packages/core/src/pipelines/Description.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/MetadataEntry.tsx

Loading...
View Options

js_modules/dagit/tox.ini

Loading...
View Options

js_modules/dagit/yarn.lock

Loading...