Page MenuHomeElementl

[dagit] Extract AppCache to top level, consolidate TestProvider
ClosedPublic

Authored by dish on May 12 2021, 9:11 PM.

Details

Summary

Move AppCache out of AppProvider so that it can be more flexible about the supplied schema. Also consolidate providers used for tests and storybook, to make it a little easier to set up specs without a ton of requirements.

Test Plan

Run Dagit to sanity check that everything is working. Jest, lint, ts.

Diff Detail

Repository
R1 dagster
Branch
dish-app-cache
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

dish requested review of this revision.May 12 2021, 9:18 PM
dish added a child revision: Restricted Differential Revision.May 14 2021, 1:53 PM
dish removed a child revision: Restricted Differential Revision.

Looks good to me! Definitely like wrapping the containers into a TestProvider

This revision is now accepted and ready to land.May 18 2021, 2:49 PM