Page MenuHomeElementl

[dagit] Extract AppCache to top level, consolidate TestProvider
ClosedPublic

Authored by dish on May 12 2021, 9:11 PM.
Tags
None
Referenced Files
F2437543: D7889.id37783.diff
Tue, Aug 16, 5:28 AM
F2437542: D7889.id.diff
Tue, Aug 16, 5:28 AM
Unknown Object (File)
Mon, Aug 15, 7:43 AM
Unknown Object (File)
Fri, Aug 12, 5:24 PM
Unknown Object (File)
Fri, Aug 12, 4:39 PM
Unknown Object (File)
Fri, Aug 12, 12:22 AM
Unknown Object (File)
Fri, Aug 12, 12:21 AM
Unknown Object (File)
Thu, Aug 11, 6:17 AM
Subscribers
None

Details

Summary

Move AppCache out of AppProvider so that it can be more flexible about the supplied schema. Also consolidate providers used for tests and storybook, to make it a little easier to set up specs without a ton of requirements.

Test Plan

Run Dagit to sanity check that everything is working. Jest, lint, ts.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish added a child revision: Restricted Differential Revision.May 14 2021, 1:53 PM
dish removed a child revision: Restricted Differential Revision.

Looks good to me! Definitely like wrapping the containers into a TestProvider

This revision is now accepted and ready to land.May 18 2021, 2:49 PM