Page MenuHomeElementl
Differential D7869

[dagit] Rename auth header (1/n)
ClosedPublic
Actions

Authored by • sidkmenon on May 11 2021, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 12, 6:04 AM
Unknown Object (File)
Wed, May 10, 3:34 PM
Unknown Object (File)
Wed, May 10, 12:50 PM
Unknown Object (File)
Wed, May 10, 9:37 AM
Unknown Object (File)
Mon, May 8, 6:59 PM
Unknown Object (File)
Apr 26 2023, 4:55 AM
Unknown Object (File)
Mar 29 2023, 10:42 PM
Unknown Object (File)
Mar 22 2023, 4:06 AM
View All 65 Files
Subscribers
None

Details

Reviewers
• dish
• dgibson
• sashank
• max
Commits
R1:79e01b54b8a7: [dagit] Rename auth header (1/n)
Summary

The authorization header was causing conflicts so I am proposing a rename to Dagster-Custom-Auth-Token.

Test Plan

spun up dagit, confirmed that Dagster-Custom-Auth-Token header is sent if headerAuthToken prop is set

Diff Detail

Repository
R1 dagster
Branch
rename-auth-header (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• sidkmenon created this revision.May 11 2021, 7:45 PM
• sidkmenon added a child revision: Restricted Differential Revision.May 11 2021, 7:47 PM
• sidkmenon added a child revision: Restricted Differential Revision.
• sidkmenon retitled this revision from [dagit] Rename auth header to [dagit] Rename auth header (1/3).
• sidkmenon edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B30415: Diff 37389.May 11 2021, 7:53 PM
• sidkmenon requested review of this revision.May 11 2021, 7:53 PM
• dgibson added reviewers: • sashank, • max.May 11 2021, 9:00 PM
• sidkmenon updated this revision to Diff 37413.May 11 2021, 9:48 PM

Renaming to Dagster-Session-Token

Harbormaster completed remote builds in B30436: Diff 37413.May 11 2021, 9:54 PM
• dgibson accepted this revision.May 12 2021, 3:07 PM
This revision is now accepted and ready to land.May 12 2021, 3:07 PM
• sidkmenon retitled this revision from [dagit] Rename auth header (1/3) to [dagit] Rename auth header (1/n).May 17 2021, 3:27 PM
Closed by commit R1:79e01b54b8a7: [dagit] Rename auth header (1/n) (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain WhyMay 17 2021, 3:38 PM
This revision was automatically updated to reflect the committed changes.
Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:79e01b54b8a7: [dagit] Rename auth header (1/n).

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
app/
2 lines

Diff 37389

View Options

js_modules/dagit/packages/core/src/app/AppProvider.tsx

Loading...