Paths

Table of Contentst

Differential D7847

[dagster-graphql][client] Fixing `reload_repository_location` and `submit_pipeline_execution`
ClosedPublic
Actions

Authored by • sidkmenon on May 10 2021, 9:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 11, 11:22 AM

	Unknown Object (File)
	May 6 2023, 11:25 PM

	Unknown Object (File)
	Apr 28 2023, 4:37 PM

	Unknown Object (File)
	Apr 10 2023, 10:21 PM

	Unknown Object (File)
	Apr 4 2023, 9:00 PM

	Unknown Object (File)
	Apr 4 2023, 3:53 AM

	Unknown Object (File)
	Mar 27 2023, 7:44 PM

	Unknown Object (File)
	Mar 18 2023, 2:15 PM

View All 82 Files

Subscribers

Details

Reviewers

• owen
• rexledesma

Commits

R1:3fead5f046a0: [dagster-graphql][client] Fixing `reload_repository_location` and…

Summary

This diff addresses GH issue 4131, in which @owen found that reload_repository_location was missing cases in the inline fragments in the underlying GraphQL query (and as a result the client would have a runtime error). When fixing this I also discovered a similar missing case for the submit_pipeline_execution method.

Also working on something to programmatically ensure that all inline fragment cases are covered for the client queries so we don't experience a regression in the future, but this diff should be enough to solve the 4131 issue.

Test Plan

bk (added new tests for the formerly missing cases for reloadRepositoryLocation and launchPipelineExecution)

Diff Detail

Repository

Branch

issue-4131 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• sidkmenon created this revision.May 10 2021, 9:38 PM

• sidkmenon edited the summary of this revision. (Show Details)May 10 2021, 9:40 PM

Harbormaster completed remote builds in B30355: Diff 37316.May 10 2021, 10:01 PM

• sidkmenon requested review of this revision.May 10 2021, 10:01 PM

nice!

This revision is now accepted and ready to land.May 10 2021, 10:51 PM

• rexledesma requested changes to this revision.May 10 2021, 11:02 PM

• rexledesma added inline comments.

docs/content/concepts/dagit/graphql-client.mdx
92	nit
python_modules/dagster-graphql/dagster_graphql/client/client.py
114	This should be more specific

This revision now requires changes to proceed.May 10 2021, 11:02 PM

rebasing & addressing comments

python_modules/dagster-graphql/dagster_graphql/client/client.py
114	not sure what this description should be, so just asked in slack. Will update ASAP.

• sidkmenon added inline comments.May 11 2021, 4:17 PM

python_modules/dagster-graphql/dagster_graphql/client/client.py
114	Updated now with description thanks to alex's help!

Harbormaster completed remote builds in B30399: Diff 37370.May 11 2021, 4:38 PM

• rexledesma accepted this revision.May 11 2021, 5:40 PM

This revision is now accepted and ready to land.May 11 2021, 5:40 PM

Closed by commit R1:3fead5f046a0: [dagster-graphql][client] Fixing `reload_repository_location` and… (authored by Sidharth Menon <menon.sid.k@gmail.com>). · Explain WhyMay 11 2021, 7:33 PM

This revision was automatically updated to reflect the committed changes.

Sidharth Menon <menon.sid.k@gmail.com> added a commit: R1:3fead5f046a0: [dagster-graphql][client] Fixing `reload_repository_location` and….

Revision Contents
Changeset List

Path

Size

docs/

content/

api/

searchindex.json

concepts/

dagit/

graphql-client.mdx

5 lines

examples/

docs_snippets/

docs_snippets/

concepts/

dagit/

graphql/

client_example.py

5 lines

python_modules/

dagster-graphql/

dagster_graphql/

client/

14 lines

client_queries.py

9 lines

3 lines

dagster_graphql_tests/

client_tests/

test_reload_repository_location.py

45 lines

test_submit_pipeline_execution.py

25 lines

graphql/

client_backcompat/

query_snapshots/

CLIENT_SUBMIT_PIPELINE_RUN_MUTATION/

dev-2021_05_10.graphql

40 lines

RELOAD_REPOSITORY_LOCATION_MUTATION/

dev-2021_05_10.graphql

24 lines

Diff 37370

docs/content/api/modules.json

Loading...

docs/content/api/searchindex.json

Loading...

docs/content/api/sections.json

Loading...

docs/content/concepts/dagit/graphql-client.mdx

Loading...

examples/docs_snippets/docs_snippets/concepts/dagit/graphql/client_example.py

Loading...

python_modules/dagster-graphql/dagster_graphql/client/client.py

Loading...

python_modules/dagster-graphql/dagster_graphql/client/client_queries.py

Loading...

python_modules/dagster-graphql/dagster_graphql/client/utils.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_reload_repository_location.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_submit_pipeline_execution.py

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/client_backcompat/query_snapshots/CLIENT_SUBMIT_PIPELINE_RUN_MUTATION/dev-2021_05_10.graphql

Loading...

python_modules/dagster-graphql/dagster_graphql_tests/graphql/client_backcompat/query_snapshots/RELOAD_REPOSITORY_LOCATION_MUTATION/dev-2021_05_10.graphql

Loading...