Differential D7842

Fix regression in line height in asset history view #4156
ClosedPublic
Actions

Authored by • bengotow on May 10 2021, 7:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 6, 8:16 AM

	Unknown Object (File)
	Wed, Feb 1, 4:01 AM

	Unknown Object (File)
	Tue, Jan 17, 5:52 PM

	Unknown Object (File)
	Dec 26 2022, 12:33 PM

	Unknown Object (File)
	Nov 17 2022, 10:55 PM

	Unknown Object (File)
	Nov 17 2022, 10:55 PM

	Unknown Object (File)
	Nov 17 2022, 10:55 PM

	Unknown Object (File)
	Nov 14 2022, 10:22 AM

View All 63 Files

Subscribers

None

Details

Reviewers

Commits

R1:82ffbbd22b41: Fix regression in line height in asset history view #4156

Summary

This resolves https://github.com/dagster-io/dagster/issues/4156, small regression I introduced in https://dagster.phacility.com/D7736. We might consider making these UIs not share code anymore since it's a bit non-intuitive that they do now that they look so different, but I'll do that next time we make significant changes.

Test Plan

Run tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• bengotow created this revision.May 10 2021, 7:48 PM

Harbormaster completed remote builds in B30344: Diff 37297.May 10 2021, 7:58 PM

• bengotow requested review of this revision.May 10 2021, 7:58 PM

• dish accepted this revision.May 10 2021, 8:06 PM

This revision is now accepted and ready to land.May 10 2021, 8:06 PM

Closed by commit R1:82ffbbd22b41: Fix regression in line height in asset history view #4156 (authored by • bengotow). · Explain WhyMay 10 2021, 8:23 PM

This revision was automatically updated to reflect the committed changes.

• bengotow added a commit: R1:82ffbbd22b41: Fix regression in line height in asset history view #4156.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

partitions/

RunMatrixUtils.tsx

1 line

Diff 37302

js_modules/dagit/packages/core/src/partitions/RunMatrixUtils.tsx

Loading...