Page MenuHomePhabricator

Use isort to sort imports
ClosedPublic

Authored by max on Thu, Aug 8, 4:49 PM.

Details

Reviewers
schrockn
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:cf1725569121: Use isort to sort imports
Summary

For style review

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Thu, Aug 8, 4:49 PM

This looks good to me. Just make sure to exclude snapshot tests

also add a run of this to the test suite.

max updated this revision to Diff 3530.Thu, Aug 8, 5:29 PM

Build and test

max updated this revision to Diff 3532.Thu, Aug 8, 5:52 PM

Black

max updated this revision to Diff 3534.Thu, Aug 8, 6:32 PM

Black

alangenfeld added inline comments.
python_modules/.isort.cfg
7

keeping this up to date seems like it will be a problem

alangenfeld accepted this revision.Fri, Aug 9, 8:35 PM

my concerns are then just
• keeping the first party list in the config up to date
• not catching isort problems at arc time

im fine with landing it and going from there
if the first party bit isnt a big benefit we should just drop it

This revision is now accepted and ready to land.Fri, Aug 9, 8:35 PM
max updated this revision to Diff 3597.Mon, Aug 12, 3:18 PM

Rebase

max updated this revision to Diff 3598.Mon, Aug 12, 3:42 PM

Fix test

max updated this revision to Diff 3600.Mon, Aug 12, 6:20 PM

Fix failing test

max updated this revision to Diff 3601.Mon, Aug 12, 6:34 PM

Black

This revision was automatically updated to reflect the committed changes.