Page MenuHomeElementl

[dagit] Fix issue rendering Gantt for dynamic pipelines with a collect that has non-dynamic inputs

Authored by bengotow on May 7 2021, 8:02 PM.
Referenced Files
F2893996: D7814.diff
Sun, Mar 26, 9:43 AM
Unknown Object (File)
Thu, Mar 23, 2:57 AM
Unknown Object (File)
Sun, Mar 19, 2:35 AM
Unknown Object (File)
Fri, Mar 10, 8:39 PM
Unknown Object (File)
Feb 12 2023, 8:56 PM
Unknown Object (File)
Feb 12 2023, 5:50 PM
Unknown Object (File)
Feb 12 2023, 5:45 PM
Unknown Object (File)
Feb 12 2023, 8:16 AM



This extends the demo pipeline slightly to cover a test case created by a user in Slack - I also refactored and commented the algorithm responsible for this so it's easier to follow.

This diff also tweaks the algorithm slightly so that upcoming (un-executed) dynamic paths are still included in the "planned" steps while the run is executing. When all of the parent steps have run, the placeholder is removed and we use the invocations observed in the logs (which may be zero). Video here:

Test Plan

Run tests, Run dynamic_pipeline with new structure

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

Show the placeholder dynamic step until the upstream steps succeed

Add missing case triggered when run is half complete

This revision is now accepted and ready to land.May 10 2021, 2:04 PM