Page MenuHomeElementl

[dagit] Prepare to remove `main` file
ClosedPublic

Authored by dish on May 7 2021, 7:42 PM.
Tags
None
Referenced Files
F2776503: D7812.id37143.diff
Wed, Feb 8, 2:14 AM
Unknown Object (File)
Mon, Feb 6, 4:32 AM
Unknown Object (File)
Jan 3 2023, 11:41 PM
Unknown Object (File)
Nov 17 2022, 10:54 PM
Unknown Object (File)
Nov 17 2022, 10:54 PM
Unknown Object (File)
Nov 17 2022, 10:54 PM
Unknown Object (File)
Nov 17 2022, 10:54 PM
Unknown Object (File)
Nov 17 2022, 10:54 PM
Subscribers
None

Details

Summary

Delete the main file, it's annoying and causes people to import the wrong thing within src. I have another way of importing these files.

Test Plan

Buildkite, sanity check Dagit.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.May 7 2021, 7:46 PM
Harbormaster failed remote builds in B30224: Diff 37139!
This revision is now accepted and ready to land.May 7 2021, 9:01 PM

I'll put main.tsx back in temporarily for now to preserve safety, and will remove it completely in a followup.

dish retitled this revision from [dagit] Remove `main` file to [dagit] Prepare to remove `main` file.May 7 2021, 9:26 PM
This revision was automatically updated to reflect the committed changes.