Page MenuHomeElementl
Differential D7812

[dagit] Prepare to remove `main` file
ClosedPublic
Actions

Authored by dish on May 7 2021, 7:42 PM.

Details

Reviewers
bengotow
Commits
R1:7c6da547e7f2: [dagit] Prepare to remove `main` file
Summary

Delete the main file, it's annoying and causes people to import the wrong thing within src. I have another way of importing these files.

Test Plan

Buildkite, sanity check Dagit.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.May 7 2021, 7:42 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 7 2021, 7:46 PM
Harbormaster failed remote builds in B30224: Diff 37139!
dish updated this revision to Diff 37143.May 7 2021, 7:50 PM

Repair dagit/app

Harbormaster completed remote builds in B30227: Diff 37143.May 7 2021, 7:57 PM
dish requested review of this revision.May 7 2021, 7:57 PM
bengotow accepted this revision.May 7 2021, 9:01 PM
This revision is now accepted and ready to land.May 7 2021, 9:01 PM
dish added a comment.May 7 2021, 9:14 PM

I'll put main.tsx back in temporarily for now to preserve safety, and will remove it completely in a followup.

dish updated this revision to Diff 37155.May 7 2021, 9:15 PM

Safety

Harbormaster completed remote builds in B30236: Diff 37155.May 7 2021, 9:23 PM
dish retitled this revision from [dagit] Remove `main` file to [dagit] Prepare to remove `main` file.May 7 2021, 9:26 PM
Closed by commit R1:7c6da547e7f2: [dagit] Prepare to remove `main` file (authored by dish). · Explain WhyMay 7 2021, 9:27 PM
This revision was automatically updated to reflect the committed changes.
dish added a commit: R1:7c6da547e7f2: [dagit] Prepare to remove `main` file.
dish mentioned this in D7881: [dagit] Delete src/main.May 12 2021, 2:05 PM
dish mentioned this in R1:c20aeaf33cea: [dagit] Delete src/main.May 16 2021, 10:34 PM

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
app/
config/
10 lines
src/
4 lines
4 lines
core/
2 lines
src/
app/
2 lines
instance/
3 lines
3 lines
2 lines

Diff 37157

View Options

js_modules/dagit/packages/app/config/webpack.config.js

Loading...
View Options

js_modules/dagit/packages/app/src/index.tsx

Loading...
View Options

js_modules/dagit/packages/app/tsconfig.json

Loading...
View Options

js_modules/dagit/packages/core/package.json

Loading...
View Options

js_modules/dagit/packages/core/src/app/AppTopNav.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/instance/InstanceSchedules.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/instance/InstanceSensors.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/instance/InstanceTabs.tsx

Loading...