Page MenuHomePhabricator

Change PresetDefinition to take raw dictionary instead of files
ClosedPublic

Authored by schrockn on Wed, Aug 7, 10:46 PM.

Details

Summary

This is much more flexible as it will allow users to programmatically generate configs

https://github.com/dagster-io/dagster/issues/1645

Test Plan

Buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Wed, Aug 7, 10:46 PM
schrockn updated this revision to Diff 3506.Wed, Aug 7, 11:01 PM
schrockn added a reviewer: Restricted Project.

up

Harbormaster completed remote builds in B2798: Diff 3504.
max accepted this revision.Thu, Aug 8, 2:43 PM
This revision is now accepted and ready to land.Thu, Aug 8, 2:43 PM