Page MenuHomePhabricator

Changes step success to mean successful execution (e.g. excluding skipped steps)
ClosedPublic

Authored by prha on Wed, Aug 7, 8:47 PM.

Details

Summary

Makes sure pipeline success is not affected by skipped steps in the process.
Adds a pipeline execution test with optional output solids.
Tracked in https://github.com/dagster-io/dagster/issues/1380

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Wed, Aug 7, 8:47 PM
prha added a reviewer: Restricted Project.Wed, Aug 7, 8:48 PM
alangenfeld accepted this revision.Wed, Aug 7, 8:51 PM
alangenfeld added a subscriber: alangenfeld.

shipit

python_modules/dagster/dagster_tests/core_tests/test_pipeline_execution.py
313–378

i question the utility of these asserts at this point - were running through step_output_event_filter so the step events will all be type output. Maybe just drop these sections?

This revision is now accepted and ready to land.Wed, Aug 7, 8:51 PM
prha updated this revision to Diff 3496.Wed, Aug 7, 8:58 PM

removed step assertions (checking not failed means nothing for output)

prha updated this revision to Diff 3497.Wed, Aug 7, 9:10 PM

lint sanitation