Page MenuHomeElementl
Differential D7711

Add override for env_name for TestPosgresInstance.docker_compose_up
ClosedPublic
Actions

Authored by max on May 3 2021, 11:50 PM.

Details

Reviewers
• sashank
jordansanders
johann
Commits
R1:a651757b370e: Add override for env_name for TestPosgresInstance.docker_compose_up
Summary

This adds the option to define a custom env_name for test Postgres instances so that we can run multiple Postgres containers in BK

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
postgres-override
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningpython_modules/dagster/dagster/utils/test/postgres_instance.py:196W0613Unused Argument
Unit
No Test Coverage

Event Timeline

• sashank updated this revision to Diff 36704.May 3 2021, 11:50 PM
• sashank created this revision.

up

• sashank retitled this revision from Add override for env_name for to Add override for env_name for TestPosgresInstance.docker_compose_up.May 3 2021, 11:53 PM
• sashank edited the summary of this revision. (Show Details)
• sashank edited the summary of this revision. (Show Details)
Harbormaster failed remote builds in B29879: Diff 36703!May 4 2021, 12:09 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2021, 12:12 AM
Harbormaster failed remote builds in B29880: Diff 36704!
max commandeered this revision.May 4 2021, 5:55 PM
max edited reviewers, added: • sashank; removed: max.
max updated this revision to Diff 36764.May 4 2021, 6:57 PM

up

max updated this revision to Diff 36765.May 4 2021, 7:16 PM

up

Harbormaster failed remote builds in B29930: Diff 36764!May 4 2021, 7:17 PM
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2021, 7:36 PM
Harbormaster failed remote builds in B29931: Diff 36765!
max updated this revision to Diff 36771.May 4 2021, 8:20 PM

up

max updated this revision to Diff 36773.May 4 2021, 8:32 PM

up

Harbormaster failed remote builds in B29937: Diff 36771!May 4 2021, 8:42 PM
Harbormaster completed remote builds in B29939: Diff 36773.May 4 2021, 8:53 PM
max requested review of this revision.May 4 2021, 8:53 PM
jordansanders accepted this revision.May 4 2021, 8:56 PM
jordansanders added a subscriber: jordansanders.
jordansanders added inline comments.
python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

That's a pretty long timeout

This revision is now accepted and ready to land.May 4 2021, 8:56 PM
johann accepted this revision.May 4 2021, 8:58 PM
• sashank added inline comments.May 4 2021, 9:01 PM
python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

25 seconds?

jordansanders added inline comments.May 4 2021, 9:03 PM
python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

To fail a build, yeah. Why do we expect the container to take so long to come up?

max updated this revision to Diff 36776.May 4 2021, 9:05 PM

up

Harbormaster completed remote builds in B29942: Diff 36776.May 4 2021, 9:24 PM
Closed by commit R1:a651757b370e: Add override for env_name for TestPosgresInstance.docker_compose_up (authored by helloworld <s@thupukari.com>, committed by max). · Explain WhyMay 4 2021, 9:32 PM
This revision was automatically updated to reflect the committed changes.
max added a commit: R1:a651757b370e: Add override for env_name for TestPosgresInstance.docker_compose_up.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
utils/
test/
17 lines
libraries/
dagster-postgres/
dagster_postgres/
2 lines

Diff 36703

View Options

python_modules/dagster/dagster/utils/test/postgres_instance.py

Loading...
View Options

python_modules/libraries/dagster-postgres/dagster_postgres/utils.py

Loading...