Page MenuHomeElementl

Add override for env_name for TestPosgresInstance.docker_compose_up
ClosedPublic

Authored by max on May 3 2021, 11:50 PM.

Details

Summary

This adds the option to define a custom env_name for test Postgres instances so that we can run multiple Postgres containers in BK

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
postgres-override
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningpython_modules/dagster/dagster/utils/test/postgres_instance.py:196W0613Unused Argument
Unit
No Test Coverage

Event Timeline

sashank retitled this revision from Add override for env_name for to Add override for env_name for TestPosgresInstance.docker_compose_up.May 3 2021, 11:53 PM
sashank edited the summary of this revision. (Show Details)
sashank edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2021, 12:12 AM
Harbormaster failed remote builds in B29880: Diff 36704!
max edited reviewers, added: sashank; removed: max.
Harbormaster returned this revision to the author for changes because remote builds failed.May 4 2021, 7:36 PM
Harbormaster failed remote builds in B29931: Diff 36765!
max requested review of this revision.May 4 2021, 8:53 PM
jordansanders added a subscriber: jordansanders.
jordansanders added inline comments.
python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

That's a pretty long timeout

This revision is now accepted and ready to land.May 4 2021, 8:56 PM
python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

25 seconds?

python_modules/libraries/dagster-postgres/dagster_postgres/utils.py
133

To fail a build, yeah. Why do we expect the container to take so long to come up?