This allows the repo locations to recover when they transition from working => error => working again
Details
Details
BK, run a grpc server against dagit, bring it down, update dagit, bring it back up, update dagit
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- serverid
- Lint
Lint Warnings Severity Location Code Message Warning python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_watch_grpc_server.py:25 W0212 Protected Access - Unit
No Test Coverage
Event Timeline
Comment Actions
Here is the stack trace I get when a server goes down: https://dagster.phacility.com/P197
It seems like there's still a problem where the callbacks fire on a background thread, but the reload code that they call isn't neccesarily thread-safe
| python_modules/dagster/dagster/cli/workspace/context.py | ||
|---|---|---|
| 230 | this is the call that is running on a background thread / is not necessarily thread safe I think? | |
Comment Actions
add a lock to Workspace since the background thread might be updating the various location dicts while the main thread is using them
Comment Actions
Amazing, this is great. Thanks for improving this substantially. One small control flow comment below.
| python_modules/dagster/dagster/cli/workspace/context.py | ||
|---|---|---|
| 230 | Thank you for fixing this | |
| python_modules/dagster/dagster/cli/workspace/workspace.py | ||
| 42–45 | I know it was already like this but we could remove the _ in front of _location_error_dict | |
| 161 | Nit: Should this use check.invariant for consistency? | |
| 210 | 👍 Thank you for moving this into the snapshot | |
| 230 | Awesome | |
| python_modules/dagster/dagster/grpc/server_watcher.py | ||
| 87 | I think this should be attempts < max_reconnect_attempts or has_error()? This current flow works, but if something stays in the error state for a long time, it's going to get kicked into the watch_for_changes loop, come back to the reconnect_loop, exhaust the attempts, and do it all over again. We can just stay in this loop in the case of an error. | |