Paths

Table of Contentst

[dagit] Split apart Instance Health query
ClosedPublic
Actions

Authored by • dish on May 3 2021, 6:45 PM.

Details

Reviewers

• prha
• bengotow
• dgibson

Commits

R1:dabbdbaa955f: [dagit] Split apart Instance Health query

Summary

Currently InstanceHealthQuery does some heavy fetching for Schedules, even if the user doesn't click the "Schedules" tab.

Break the page and its query apart.

Test Plan

View /instance, then each tab. Verify that querying and refreshing work properly.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.May 3 2021, 6:45 PM

Harbormaster completed remote builds in B29833: Diff 36650.May 3 2021, 7:04 PM

• dish requested review of this revision.May 3 2021, 7:04 PM

thanks!

This revision is now accepted and ready to land.May 4 2021, 12:46 AM

Closed by commit R1:dabbdbaa955f: [dagit] Split apart Instance Health query (authored by • dish). · Explain WhyMay 4 2021, 1:42 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:dabbdbaa955f: [dagit] Split apart Instance Health query.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

instance/

InstanceBackfills.tsx

133 lines

InstanceConfig.tsx

38 lines

InstanceHealthPage.tsx

56 lines

InstanceRoot.tsx

5 lines

InstanceSchedules.tsx

80 lines

InstanceSensors.tsx

80 lines

InstanceStatusRoot.tsx

120 lines

InstanceTabs.tsx

37 lines

types/

InstanceHealthForBackfillsQuery.ts

InstanceHealthQuery.ts

InstanceSchedulesQuery.ts

InstanceSensorsQuery.ts

Diff 36729

View Options

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceConfig.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceHealthPage.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceRoot.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceSchedules.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceSensors.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceStatusRoot.tsx

View Options

js_modules/dagit/packages/core/src/instance/InstanceTabs.tsx

View Options

js_modules/dagit/packages/core/src/instance/types/InstanceHealthForBackfillsQuery.ts

View Options

js_modules/dagit/packages/core/src/instance/types/InstanceHealthQuery.ts

View Options

js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts

View Options

js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts

[dagit] Split apart Instance Health queryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36729

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx

js_modules/dagit/packages/core/src/instance/InstanceConfig.tsx

js_modules/dagit/packages/core/src/instance/InstanceHealthPage.tsx

js_modules/dagit/packages/core/src/instance/InstanceRoot.tsx

js_modules/dagit/packages/core/src/instance/InstanceSchedules.tsx

js_modules/dagit/packages/core/src/instance/InstanceSensors.tsx

js_modules/dagit/packages/core/src/instance/InstanceStatusRoot.tsx

js_modules/dagit/packages/core/src/instance/InstanceTabs.tsx

js_modules/dagit/packages/core/src/instance/types/InstanceHealthForBackfillsQuery.ts

js_modules/dagit/packages/core/src/instance/types/InstanceHealthQuery.ts

js_modules/dagit/packages/core/src/instance/types/InstanceSchedulesQuery.ts

js_modules/dagit/packages/core/src/instance/types/InstanceSensorsQuery.ts

[dagit] Split apart Instance Health query
ClosedPublic
Actions

Revision Contents
Changeset List