Page MenuHomeElementl

[dagit] Make RunsSearchSpaceQuery lazy
ClosedPublic

Authored by dish on Apr 30 2021, 7:29 PM.

Details

Summary

It turns out that RunsSearchSpaceQuery is pretty expensive. Make it lazy, waiting for the user to focus the input.

Test Plan

View Runs in Dagit, focus the filter input. Verify that it performs the query at this point and no sooner.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Apr 30 2021, 7:36 PM
This revision is now accepted and ready to land.Apr 30 2021, 10:14 PM

Oh nice! This seems like a nice solution ๐Ÿ‘

This revision was automatically updated to reflect the committed changes.