Save logs to `$DAGSTER_HOME/logs/v0/repo_name'
- Group Reviewers
- R1:0c0ff0c534b5: [cron] Save logs to ~/dagster directory
Run dagit --log
Check contents of `$DAGSTER_HOME/logs/experimental/repo_name'
Re-run dagit and confirm run loads properly
Airflow sets up $AIRFLOW_HOME during installation, and uses the default of ~/airflow
What do you think about doing the same during our install, and removing the default in the code here?
interesting - I could be convinced otherwise but the experience that I think i would want is:
- don't set it by default
- error if it is not set and --log is passed without --log-dir: have error message indicate both options of using --log-dir or setting $DAGSTER_HOME
- don't mention it in the install instructions since its only used in this one place so far
- probably drop the v0 bit unless you think that its a really good idea - i was just throwing ideas out there
I think if more stuff depends on it it will make sense to change the behavior - but this is where i land at the moment
this seems fine for now
for example: I have dagster checked out to ~/dagster - what happens when i run this? it just starts writing stuff in to my git checkout? Do we need to have some marker file that we look for / write on first initialization? At least having it explicitly set means that a user has to navigate these problems and we can reasonably assume they have set DAGSTER_HOME To something not already used. Not sure how airflow handles this case.
I go back and forth on this 'v0' bit - maybe we should just do beta or something to indicate instability. v0 feels like its locking us in to a versioning scheme.
experimental is another good alternative if beta feels off
we should do a check here for if the home dir is not set and throw a more useful error message - that and/or update the help text for --log to indicate thats where we are going to go look for it