Page MenuHomeElementl

[Depends on D7674] Refactor lambda_solid as a simple wrapper around _Solid
ClosedPublic

Authored by cdecarolis on Apr 30 2021, 2:21 PM.

Details

Summary

After the changes in D7674, solid pretty much subsumes the functionality of lambda_solid. To preserve backcompat, preserve the decorator as a simple wrapper over the @solid machinery.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 30 2021, 2:40 PM
Harbormaster failed remote builds in B29745: Diff 36537!

Fix to allow _ to be used as an input name on lambda_solid.

Wait for refactor

python_modules/dagster/dagster/core/definitions/decorators/solid.py
463–508

i dont know if we need a deprecation warning - but we can probably communicate something to that effect here since there is like no need for this anymore thanks to the changes in @solid

il defer to @sandyryza here on how exactly to frame whether this is deprecated, legacy, or whatever

There's no situation where we'd expect a user to use it, right? If so, IMO we should document it as deprecated.

On whether to have a deprecation warning, my instinct is no. I don't think there's any rush to actually remove it, given how small its footprint is.

@schrockn might have opinions.

I think we can just remove it from all docs and examples and leave it as undeprecated since the cost of keeping it around is low

Update examples, remove lambda_solid from API docs

This revision is now accepted and ready to land.May 11 2021, 5:45 PM