Page MenuHomeElementl

[dagit] Remove react-scripts from @dagit/core
ClosedPublic

Authored by dish on Apr 29 2021, 10:05 PM.

Details

Summary

Now that the Dagit CRA is ejected, remove react-scripts from @dagit/core. It currently uses it for running Jest, but we can just set that up ourselves.

Test Plan

Buildkite, run yarn why react-scripts to verify that it's gone.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 29 2021, 10:10 PM
Harbormaster failed remote builds in B29730: Diff 36516!
dish requested review of this revision.Apr 30 2021, 1:18 AM
This revision is now accepted and ready to land.May 3 2021, 12:39 PM
This revision was automatically updated to reflect the committed changes.