Page MenuHomePhabricator

[cron] Save dagster-graphql runs to filesystem
ClosedPublic

Authored by sashank on Aug 5 2019, 9:52 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:83eeafa7e42c: [cron] Save dagster-graphql runs to filesystem
Summary
  • Add --log and --log-dir flags to dagster-graphql to save runs
  • Create --log-dir directory if it doesn't exist
Test Plan

Run

dagster-graphql -v "cat variables.txt`" -y repository.yaml "cat query.graphql" --log`

File contents:

variables.txt

{
  "executionParams": {
    "environmentConfigData": {
      "storage": {
        "filesystem": null
      }
    },
    "selector": {
      "name": "many_events",
      "solidSubset": null
    },
    "mode": "default"
  }
}

query.graphql

mutation StartPipelineExecution($executionParams: ExecutionParams!) {
  startPipelineExecution(executionParams: $executionParams) {
    __typename
    ... on StartPipelineExecutionSuccess {
      run {
        runId
        __typename
      }
      __typename
    }
    ... on PipelineNotFoundError {
      message
      __typename
    }
    ... on PipelineConfigValidationInvalid {
      errors {
        message
        __typename
      }
      __typename
    }
  }
}

Shows up in dagit:

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Aug 5 2019, 9:52 PM
sashank retitled this revision from [cron] Save dagster-grqphql runs to filesystem to [cron] Save dagster-graphql runs to filesystem.Aug 5 2019, 10:36 PM
sashank edited the summary of this revision. (Show Details)
sashank edited the test plan for this revision. (Show Details)
alangenfeld accepted this revision.Aug 5 2019, 10:36 PM
alangenfeld added a subscriber: alangenfeld.
alangenfeld added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/pipeline_run_storage.py
38

lets improve the default directory experience ASAP

This revision is now accepted and ready to land.Aug 5 2019, 10:36 PM