Page MenuHomeElementl

Default to re-executing step selection of current run if one is present
ClosedPublic

Authored by bengotow on Apr 28 2021, 5:33 AM.

Details

Summary

This diff addresses https://github.com/dagster-io/dagster/issues/3974

  • If you select a few steps and re-execute them, the re-execute button offers to run that same step selection again by default
  • This option is distinct from "All Steps" which re-runs all the steps in the original run's scope (pipeline + SOLID selection), not the current view. I attempted to make this more clear by changing this option to be "Full Pipeline", but this may not be sufficient to capture that it does scope to your initial solid selection. "Full Scope" or "Full Solid Subset" would be nice too.
  • I cleaned up the props passed to RunActionButtons and moved a few things into helpers.

image.png (988×2 px, 302 KB)

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 28 2021, 9:00 PM

Alas I think "Full Pipeline" is misleading for the reason you mentioned. I agree that this is a tough one. Would something like "All Steps in Root Run" too long?

drive by thought: agreed "full pipeline" is misleading (and i was the one that named it). maybe "Root Run (<insert solid selection if applicable>)"

I think "All Steps in Root Run" sounds pretty good! It's super explicit which I think is preferable at this point... Root Run <Solid Selection> would work too but I'm a bit worried about a solid query making it too long. Will go with this for now and we can iterate if we come up with anything better!

image.png (566×876 px, 99 KB)