Page MenuHomePhabricator

New GE-Dagster integration prototype
ClosedPublic

Authored by schrockn on Mon, Aug 5, 1:55 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:6e2badd07815: New GE-Dagster integration prototype
Summary

Here is a simple integration of a great expectations + plus dagster integration. All this does is lightly
massage the GE EVR data structure into the Dagster ExpectationResult.

Test Plan

Buildkite. Run in dagit (see screenshots)

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Mon, Aug 5, 1:55 PM
schrockn edited the summary of this revision. (Show Details)Mon, Aug 5, 1:55 PM

alangenfeld accepted this revision.Mon, Aug 5, 3:52 PM
alangenfeld added a subscriber: alangenfeld.

seems like a good place to start

python_modules/libraries/dagster-ge/dagster_ge/__init__.py
0–26

rm

This revision is now accepted and ready to land.Mon, Aug 5, 3:52 PM

UI nit: Should failure be red instead of yellow/orange?

max added a subscriber: max.Mon, Aug 5, 5:08 PM

I think it's a little subtle to know what color to make / how to signal expectation failure

This diff doesn't change the UI at all. If we want to address that we should file an issue and address in a follow up

schrockn updated this revision to Diff 3408.Mon, Aug 5, 5:58 PM
schrockn edited the summary of this revision. (Show Details)
schrockn removed a reviewer: alangenfeld.

feedback

This revision now requires review to proceed.Mon, Aug 5, 5:58 PM
schrockn updated this revision to Diff 3409.Mon, Aug 5, 6:58 PM
schrockn added a reviewer: alangenfeld.

up

schrockn updated this revision to Diff 3410.Mon, Aug 5, 7:00 PM

fix reviewed by

alangenfeld accepted this revision.Mon, Aug 5, 8:06 PM
This revision is now accepted and ready to land.Mon, Aug 5, 8:06 PM
This revision was automatically updated to reflect the committed changes.