Page MenuHomeElementl

[dagit] Prevent overscroll on hscroll containers
ClosedPublic

Authored by dish on Apr 26 2021, 10:19 PM.

Details

Summary

Resolves #3269

Prevent overscroll from triggering navigation on hscroll grid containers (Assets, Partitions), at least in Chrome and Firefox. Safari doesn't appear to support overscroll-behavior yet.

Test Plan

Open asset with materialization grid, try hscrolling too far to the left with scroll gesture. Verify that overscrolling is blocked. Repeat in Firefox.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Apr 26 2021, 10:26 PM

Oh nice! This is great - I had no idea there was a CSS property for this, good find. ๐Ÿ™Œ

This revision is now accepted and ready to land.Apr 26 2021, 11:05 PM
This revision was automatically updated to reflect the committed changes.