Page MenuHomeElementl

Add storybooks for Gannt chart UI, show hh:mm:ss when clicking Gannt steps #4042
ClosedPublic

Authored by bengotow on Apr 26 2021, 9:46 PM.

Details

Summary
  • The actual fix for #4042 is just calling a more appropriate helper method.
  • I also discovered that if bad input data is fed to the Gannt chart time "ticks" method, it can crash the browser trying to render millions of ticks, so I've improved that failure case.
  • I've added a storybook for the Gantt UI that renders both the empty + loaded states, and uses the Storybook "controls" concept to let you scrub through time in a sample run. This involves a fair bit of handmade data but I think a big blob of JSON is a bit unavoidable here.
Test Plan

Check out new storybook!

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish added inline comments.
js_modules/dagit/packages/core/src/runs/RunMetadataProvider.tsx
77
This revision is now accepted and ready to land.Apr 28 2021, 8:56 PM