Page MenuHomeElementl

[dagster-postgres] [easy] Quick fix in listen/notify logic
ClosedPublic

Authored by sidkmenon on Apr 26 2021, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2023, 8:25 AM
Unknown Object (File)
May 8 2023, 8:21 AM
Unknown Object (File)
May 8 2023, 3:15 AM
Unknown Object (File)
Apr 23 2023, 2:26 PM
Unknown Object (File)
Apr 11 2023, 11:00 AM
Unknown Object (File)
Mar 22 2023, 10:03 AM
Unknown Object (File)
Mar 11 2023, 12:32 AM
Unknown Object (File)
Feb 12 2023, 5:01 PM
Subscribers
None

Details

Summary

There was an unclear isinstance call on the notifications yielded from await_pg_notifications as a NoneType check - a better pattern is the is not None check.

I think the reason this was there in the first place is that older versions of the await_pg_notifications code would occasionally yield a integer signal.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
quick-pg-fix (branched from master)
Lint
Lint Passed
Unit
No Test Coverage