Page MenuHomeElementl

[dagster-postgres] [easy] Quick fix in listen/notify logic
ClosedPublic

Authored by sidkmenon on Apr 26 2021, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 22, 10:03 AM
Unknown Object (File)
Sat, Mar 11, 12:32 AM
Unknown Object (File)
Feb 12 2023, 5:01 PM
Unknown Object (File)
Feb 12 2023, 1:19 PM
Unknown Object (File)
Feb 12 2023, 12:19 PM
Unknown Object (File)
Feb 6 2023, 6:47 PM
Unknown Object (File)
Jan 31 2023, 7:45 AM
Unknown Object (File)
Dec 17 2022, 2:07 AM
Subscribers
None

Details

Summary

There was an unclear isinstance call on the notifications yielded from await_pg_notifications as a NoneType check - a better pattern is the is not None check.

I think the reason this was there in the first place is that older versions of the await_pg_notifications code would occasionally yield a integer signal.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable