unit
Details
Details
- Reviewers
alangenfeld - Group Reviewers
Restricted Project - Commits
- R1:72062de748f6: Add Dagster bash solid
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
hm maybe '[bash][{name}]' instead of '[bash solid]'?
| python_modules/libraries/dagster-bash/dagster_bash/solids.py | ||
|---|---|---|
| 69–73 | ehh this seems like it would suck - maybe we should have an enum to control the output logging behavior BUFFER / STREAM / NONE | |
| python_modules/libraries/dagster-bash/dagster_bash/solids.py | ||
|---|---|---|
| 69–73 | should probably do the same thing for spark too - that has the same bad logging output experience right | |
| python_modules/libraries/dagster-bash/dagster_bash/solids.py | ||
|---|---|---|
| 69–73 | yeah that's a good idea - let me at least do it here, I need to think a little more about how best to handle the Spark case | |
| python_modules/libraries/dagster-bash/dagster_bash/solids.py | ||
|---|---|---|
| 89 | maybe output_logging or something else a little more specific, output_type feels too vague | |