[dagit] Give asset catalog list a new stacking context
ClosedPublic
Actions

Authored by dish on Apr 22 2021, 9:04 PM.

Details

Reviewers

bengotow
prha

Commits

R1:c2f7628f4abb: [dagit] Give asset catalog list a new stacking context

Summary

Bug: the flat/folder button group on the asset list view has a z-index, given to it by blueprint, which puts it on top of the sliding left nav.

Fix this by giving the component a new stacking context.

Test Plan

Shrink the viewport width, navigate to assets. Open the left nav, verify that the buttons no longer show through it.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dish created this revision.Apr 22 2021, 9:04 PM

Bug looks like:

Harbormaster completed remote builds in B29363: Diff 36047.Apr 22 2021, 9:11 PM

dish requested review of this revision.Apr 22 2021, 9:11 PM

prha accepted this revision.Apr 22 2021, 10:24 PM

This revision is now accepted and ready to land.Apr 22 2021, 10:24 PM

Closed by commit R1:c2f7628f4abb: [dagit] Give asset catalog list a new stacking context (authored by dish). · Explain WhyApr 23 2021, 3:03 PM

This revision was automatically updated to reflect the committed changes.

dish added a commit: R1:c2f7628f4abb: [dagit] Give asset catalog list a new stacking context.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

assets/

AssetsCatalogTable.tsx

2 lines

Diff 36071

View Options

js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx

[dagit] Give asset catalog list a new stacking contextClosedPublicActions