Page MenuHomeElementl

fix asset directory navigation
ClosedPublic

Authored by prha on Apr 21 2021, 4:12 PM.

Details

Summary

We weren't respecting the directory flag structure as you navigated into subdirectories.
This diff uses query state to keep track of the view state and maintains as you navigate

Also removed the feature flag

Test Plan

Clicked through directory structure, saw that subdirectories kept the same view.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha requested review of this revision.Apr 21 2021, 4:19 PM

Does there need to be a mechanism to go "up" a directory level while navigating?

js_modules/dagit/packages/core/src/assets/AssetsCatalogTable.tsx
498–500
This revision is now accepted and ready to land.Apr 22 2021, 12:56 PM

There are breadcrumbs in the page header if you go more than one level down.

This revision was automatically updated to reflect the committed changes.