Preliminary to selecting engines through Dagit -- first make sure that we are using a single code path for all of our execution modalities.
- R1 dagster
Lint Warnings Excuse: no init needed Severity Location Code Message Warning python_modules/dagster-graphql/dagster_graphql/implementation/pipeline_execution_manager.py:35 W0232 No Init
No Unit Test Coverage
can you update the summary with a little detail as to how these changes set us up for further improvement? I don't see any objectionable code changes here, but its also not immediately obvious where this is going.
is there a reason to do it this way vs importing the pipeline directly?
Yep, the second phase eliminates executor_config from RunConfig entirely, specifying it through the environment dict. It's key for this that all of our execution modalities use a single code path.
yes, only pipelines instantiated from handles can be executed across process boundaries
maybe check to ensure that config doesn't have multiple items since you're doing single_item here?
|248 ↗||(On Diff #3404)|
does this have test coverage? since you're promoting to utils might be nice to write a small test to demo what it does