Page MenuHomeElementl

Add container_kwargs to DockerRunLauncher
ClosedPublic

Authored by dgibson on Apr 20 2021, 2:18 PM.

Details

Summary

Rather than individually adding config as use cases come up (auto_remove, volumes, etc.), let config give users direct access to the full containers.create API via kwargs.

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sashank added inline comments.
python_modules/libraries/dagster-docker/dagster_docker/docker_run_launcher.py
173–178

Might be nice to throw a helpful error if they try to pass one of these pre-defined kwargs that is set by us or another config field.

This revision is now accepted and ready to land.Apr 20 2021, 2:39 PM

add some validation on duplicates in the non-kwargs args

This revision was automatically updated to reflect the committed changes.