Page MenuHomeElementl

in check functions, remove raise_with_traceback and convert to f-strings
ClosedPublic

Authored by sandyryza on Apr 19 2021, 4:22 PM.

Details

Summary

The primary motivation for this change is to remove an un-useful frame from the stack traces that users see when they hit a check error.

That change uncovered a mypy error, which I fixed by replacing Set with AbstractSet in a bunch of different places.

While on the theme of python 3 stuff, I made some format->f-string conversions in the check module. I ran out of steam before completing all of them, but I still think this is an improvement.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sandyryza added a reviewer: max.
sandyryza edited the summary of this revision. (Show Details)
sandyryza edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2021, 4:39 PM
Harbormaster failed remote builds in B29061: Diff 35667!

it might be helpful to have a comment on why AbstractSet is required at the top of the file

This revision is now accepted and ready to land.Apr 19 2021, 8:27 PM