Page MenuHomeElementl

[Helm] Allow configuration of postgres connection string on storage classes
AbandonedPublic

Authored by rexledesma on Apr 16 2021, 7:17 AM.

Details

Reviewers
johann
prha
Summary

In response to a user request from https://dagster.slack.com/archives/CCCR6P2UR/p1618395836169300.

We already allow the postgres storage classes to be configured by a postgres connection string, but
we don't expose this capability in Kubernetes. Here, we implement the threading for this config value.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Branch
rl/helm-postgresql-string (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

More complicated than expected - will have to update the k8s run launchers to take in postgres_connection_string_secret rather than postgres_password_secret

It might be helpful to get more context from the user, are there cases where they couldn't just pull out the user/password/etc? Looks like it wouldn't be too hard postgresql://[user[:password]@][netloc][:port][/dbname][?param1=value1&...]

@johann yeah I might have went about this a goofy way - it's probably more simpler to just expose a new field postgres_db.db_params in the storage config, and then just append the urlencoded values to the generated postgresql connection string

Abandoning in favor of the simpler D7525