Page MenuHomeElementl

Fix issue with error handling in ProcessGrpcServerRegistry
ClosedPublic

Authored by dgibson on Apr 16 2021, 4:01 AM.

Details

Summary

If there was an error loading a repository in the gRPC server, subsequent attempts to fetch the gRPC endpoint for that origin would hit an unexpected error (instead of raising the intended user code error)

This was actually a regression introduced in https://dagster.phacility.com/D7458 to aid with the release pipeline (ironically) - if that made it into the release branch it might be worth including this fix in said release.

Test Plan

New test case that was failing before

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

make a namedtuple for these instead of a gross regular tuple

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/test_grpc_server_registry.py
62

before this was raising an Attributeerror instead in the server_refresh check above because it wasn't handling the case where there was an error while loading the process

I'd like to try to cherry pick this if reviewers have a sec (since the blamerev is going out in the release)

prha added inline comments.
python_modules/dagster/dagster/core/host_representation/grpc_server_registry.py
59–76

nice

This revision is now accepted and ready to land.Apr 16 2021, 3:30 PM