Page MenuHomeElementl

Increase the number of typeahead autocompletions shown and scroll the list #4017
ClosedPublic

Authored by bengotow on Thu, Apr 15, 8:25 PM.

Details

Summary

This diff increases the number of visible results and makes the autocompletion dropdown scroll. There's still a limit on the number of items shown (for React's sake) but it's more of a cap than a display choice.

Test Plan

Type tag:, status: in dropdown

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Fri, Apr 16, 2:01 PM

When scrolling down with the keyboard, does the scrollable div keep the highlighted item visible? (If not: the typeahead dropdown code for global search and log filtering does do this, so we can either try to reuse that code here or copy it over temporarily.)

Ahh good catch it lets you move the selection out of view. Will fix this!

  • Keep the active item visible as you use the keyboard to navigate
This revision is now accepted and ready to land.Mon, Apr 19, 7:34 PM
  • Keep the active item visible as you use the keyboard to navigate