Page MenuHomeElementl

Handle long lists of parent assets #3952
ClosedPublic

Authored by bengotow on Apr 15 2021, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 1:40 AM
Unknown Object (File)
Mon, Jun 27, 1:57 AM
Unknown Object (File)
Sun, Jun 26, 9:39 PM
Unknown Object (File)
Sat, Jun 25, 5:14 AM
Unknown Object (File)
Thu, Jun 23, 9:46 PM
Unknown Object (File)
Fri, Jun 17, 9:57 PM
Unknown Object (File)
Thu, Jun 16, 7:40 AM
Unknown Object (File)
Mon, Jun 13, 2:19 AM
Subscribers
None

Details

Summary

This diff adds truncation to the list and a "Show More" toggle

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish added inline comments.
js_modules/dagit/packages/core/src/assets/AssetLineageElements.tsx
39

If no spacing, then just a list of divs instead of using Group?

This revision is now accepted and ready to land.Apr 16 2021, 2:04 PM
  • Eliminate needless “Group” in AssetLineageElements
  • Fix storybook config and update storybook deps
  • Add storybook for AssetLineageElements