Page MenuHomeElementl
Differential D7465

Handle long lists of parent assets #3952
ClosedPublic
Actions

Authored by • bengotow on Apr 15 2021, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 1:40 AM
Unknown Object (File)
Mon, Jun 27, 1:57 AM
Unknown Object (File)
Sun, Jun 26, 9:39 PM
Unknown Object (File)
Sat, Jun 25, 5:14 AM
Unknown Object (File)
Thu, Jun 23, 9:46 PM
Unknown Object (File)
Fri, Jun 17, 9:57 PM
Unknown Object (File)
Thu, Jun 16, 7:40 AM
Unknown Object (File)
Mon, Jun 13, 2:19 AM
View All 10 Files
Subscribers
None

Details

Reviewers
• dish
Commits
R1:8bbce35a779c: Handle long lists of parent assets #3952
Summary

This diff adds truncation to the list and a "Show More" toggle

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• bengotow created this revision.Apr 15 2021, 8:22 PM
Harbormaster completed remote builds in B28947: Diff 35526.Apr 15 2021, 8:30 PM
• bengotow requested review of this revision.Apr 15 2021, 8:30 PM
• dish accepted this revision.Apr 16 2021, 2:04 PM
• dish added inline comments.
js_modules/dagit/packages/core/src/assets/AssetLineageElements.tsx
39

If no spacing, then just a list of divs instead of using Group?

This revision is now accepted and ready to land.Apr 16 2021, 2:04 PM
• bengotow updated this revision to Diff 35661.Apr 19 2021, 3:41 PM
  • Eliminate needless “Group” in AssetLineageElements
  • Fix storybook config and update storybook deps
  • Add storybook for AssetLineageElements
Harbormaster completed remote builds in B29056: Diff 35661.Apr 19 2021, 3:49 PM
Closed by commit R1:8bbce35a779c: Handle long lists of parent assets #3952 (authored by • bengotow). · Explain WhyApr 19 2021, 4:08 PM
This revision was automatically updated to reflect the committed changes.
• bengotow added a commit: R1:8bbce35a779c: Handle long lists of parent assets #3952.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
.storybook/
packages/
core/
.storybook/
8 lines
18 lines
src/
assets/
12 lines
57 lines
46 lines
14 lines
packages/
core/
.storybook/
.storybook/
2 lines
1890 lines

Diff 35663

View Options

js_modules/dagit/.storybook/main.js

Loading...
View Options

js_modules/dagit/.storybook/preview.js

Loading...
View Options

js_modules/dagit/packages/core/.storybook/main.js

Loading...
View Options

js_modules/dagit/packages/core/.storybook/preview.js

Loading...
View Options

js_modules/dagit/packages/core/package.json

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetDetails.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetLineageElements.stories.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetLineageElements.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetLineageInfoElement.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/assets/AssetMaterializationTable.tsx

Loading...
View Options

js_modules/dagit/yarn.lock

Loading...