Page MenuHomeElementl

Remove pyrsistent
ClosedPublic

Authored by schrockn on Apr 15 2021, 1:51 PM.

Details

Summary

This was used in the in-memory event log for synchronization.
However this is only used and useful in the ephmeral instance, and I
don't think the in-memory event log needs to be thread-safe.
Theorectically someone could invoke execute pipeline in two different
threads sharing the same ephemeral instance, but I think that is quite
fringe.

If we feel strongly that the in-memory case should remain thread safe
(e.g. with an threaded executor) we can add some synchronizsation
primitives to this

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schrockn edited the summary of this revision. (Show Details)
schrockn added reviewers: dgibson, alangenfeld.

up

This revision is now accepted and ready to land.Apr 15 2021, 2:32 PM
schrockn retitled this revision from Remove pyrsitent to Remove pyrsistent.

up

This revision was landed with ongoing or failed builds.Apr 15 2021, 2:52 PM
Closed by commit R1:d506da7796c5: Remove pyrsistent (authored by schrockn). · Explain Why
This revision was automatically updated to reflect the committed changes.