Page MenuHomeElementl

default config schema to Any
ClosedPublic

Authored by sandyryza on Apr 15 2021, 12:15 AM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 15 2021, 12:33 AM
Harbormaster failed remote builds in B28883: Diff 35451!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 15 2021, 3:55 AM
Harbormaster failed remote builds in B28887: Diff 35459!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 15 2021, 3:47 PM
Harbormaster failed remote builds in B28909: Diff 35484!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 15 2021, 4:25 PM
Harbormaster failed remote builds in B28918: Diff 35493!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 15 2021, 4:47 PM
Harbormaster failed remote builds in B28923: Diff 35499!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 16 2021, 12:53 AM
Harbormaster failed remote builds in B28976: Diff 35560!

should any docs or tutorials get updated in this diff as well?

i think we should update all the config_schema arg docstrings to mention this default behavior, e.g. in @solid, SolidDefinition, @resource, and a lot more - esp composite and io manager will behave differently.

We also need to determine the fate of the dagit "config nub" with this change. cc: @bengotow

seems to be general support here so sending to your queue for final polish

I dont think we need to block on any dagit cleanup, that can come after. I do think the API docs / tutorial updates should get updated

This revision now requires changes to proceed.Apr 19 2021, 9:10 PM

noice

docs/content/tutorial/intro-tutorial/configuring-solids.mdx
150

Schematizing

nit: this is an intense word - wonder if just "config schema" or something would be better

150–182

yesss this progression of complexity is excellent

This revision is now accepted and ready to land.Apr 20 2021, 4:42 PM
This revision was automatically updated to reflect the committed changes.