fix non-required fields in IOManager output_config_schemas
ClosedPublic
Actions

Authored by sandyryza on Apr 15 2021, 12:11 AM.

Details

Reviewers

cdecarolis
yuhan

Commits

R1:5a6fb8293c0a: fix non-required fields in IOManager output_config_schemas

Summary

Before this change, the added test would fail. I.e. is_required would not be respected in output/input config schemas for IOManagers and RootInputManagers.

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sandyryza created this revision.Apr 15 2021, 12:11 AM

sandyryza added a child revision: D7446: default config schema to Any.Apr 15 2021, 12:15 AM

Harbormaster completed remote builds in B28881: Diff 35449.Apr 15 2021, 12:33 AM

sandyryza requested review of this revision.Apr 15 2021, 12:33 AM

yuhan accepted this revision.Apr 16 2021, 8:13 PM

This revision is now accepted and ready to land.Apr 16 2021, 8:13 PM

Closed by commit R1:5a6fb8293c0a: fix non-required fields in IOManager output_config_schemas (authored by sandyryza). · Explain WhyApr 19 2021, 8:57 PM

This revision was automatically updated to reflect the committed changes.

sandyryza added a commit: R1:5a6fb8293c0a: fix non-required fields in IOManager output_config_schemas.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

definitions/

environment_configs.py

4 lines

dagster_tests/

core_tests/

storage_tests/

test_io_manager.py

25 lines

Diff 35716

View Options

python_modules/dagster/dagster/core/definitions/environment_configs.py