Page MenuHomePhabricator

Fixes for dagster-airflow scaffold CLI
ClosedPublic

Authored by natekupp on Tue, Jul 30, 6:00 PM.

Details

Reviewers
max
Group Reviewers
Restricted Project
Commits
R1:fde36da5c724: Fixes for dagster-airflow scaffold CLI
Summary

This adds support for presets and adopts the same CLI interface as dagster proper

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Tue, Jul 30, 6:00 PM
natekupp added a reviewer: Restricted Project.Tue, Jul 30, 7:57 PM
natekupp edited the summary of this revision. (Show Details)
max requested changes to this revision.Tue, Jul 30, 8:23 PM
max added a subscriber: max.

I just want to avoid multiple conflicting implementations of get_system_temp_directory

python_modules/dagster-airflow/dagster_airflow/cli.py
33

let's standardize on dagster.seven.temp_dir.get_system_temp_directory

135

use check?

This revision now requires changes to proceed.Tue, Jul 30, 8:23 PM
natekupp marked 2 inline comments as done.Tue, Jul 30, 8:48 PM
natekupp added inline comments.
python_modules/dagster-airflow/dagster_airflow/cli.py
33

thanks :)

135

ah, of course - yes, thanks!

natekupp updated this revision to Diff 3343.Tue, Jul 30, 8:48 PM
natekupp marked 2 inline comments as done.

comments

max accepted this revision.Tue, Jul 30, 11:09 PM
This revision is now accepted and ready to land.Tue, Jul 30, 11:09 PM