Page MenuHomeElementl

add view switcher for directory vs flat views of the asset catalog
ClosedPublic

Authored by prha on Tue, Apr 13, 12:30 AM.

Details

Summary

Rather than using the feature flags, allow folks to switch between the flat view and the
hierarchical view using a button toggle

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha requested review of this revision.Tue, Apr 13, 12:40 AM

Two thoughts:

  • Can we add tool-tips?
  • The four stacked lines reminds me of a hamburger menu, which makes me suspect that clicking it would open up a nav or something. I don't have any bright ideas, but is there an icon that would be less likely to have that connotation.

@sandyryza, we have titles.... do you think we need tooltips? Or were you thinking that they'd have a longer text description?

Re: icon, what do you think about

Screen Shot 2021-04-13 at 2.08.22 PM.png (133×180 px, 7 KB)

That icon looks good to me. I also just noticed that Finder has the four vertical lines for a non-nav use case, so maybe I'm overreacting.

image.png (188×688 px, 28 KB)

Are the titles you're mentioning included in that video you added and I'm missing them?

You have to wait a little bit longer, but it's nice because it's using normal HTML instead of some popup shenanigans.

Ah cool - those look good to me.

This revision is now accepted and ready to land.Tue, Apr 13, 9:28 PM