Page MenuHomeElementl

fix main content margin for wide screens
ClosedPublic

Authored by prha on Apr 12 2021, 4:10 PM.

Details

Diff Detail

Repository
R1 dagster
Branch
prha/wide_screen
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

prha requested review of this revision.Apr 12 2021, 4:17 PM

Ah man, sorry about this. Unfortunately it requires a bit more.

--- a/js_modules/dagit/packages/core/src/app/App.tsx
+++ b/js_modules/dagit/packages/core/src/app/App.tsx
@@ -43,11 +43,8 @@ export const App = () => {
 const Main = styled.div<{$navOpen: boolean}>`
   height: 100%;
   width: 100%;
-
-  @media (max-width: 2560px) {
-    margin-left: 280px;
-    width: calc(100% - 280px);
-  }
+  margin-left: 280px;
+  width: calc(100% - 280px);

   @media (max-width: 1440px) {
     margin-left: 0;
diff --git a/js_modules/dagit/packages/core/src/app/AppTopNav.tsx b/js_modules/dagit/packages/core/src/app/AppTopNav.tsx
index 296b813b0..f511bdbaa 100644
--- a/js_modules/dagit/packages/core/src/app/AppTopNav.tsx
+++ b/js_modules/dagit/packages/core/src/app/AppTopNav.tsx
@@ -101,6 +101,7 @@ const LogoWebsocketStatus = styled(WebsocketStatus)`
 const NavButton = styled.button`
   border-radius: 16px;
   cursor: pointer;
+  display: none;
   margin-left: 4px;
   outline: none;
   padding: 6px;
@@ -123,10 +124,6 @@ const NavButton = styled.button`
     background: ${Colors.DARK_GRAY5};
   }

-  @media (max-width: 2560px) {
-    display: none;
-  }
-
   @media (max-width: 1440px) {
     display: block;
   }
dish requested changes to this revision.Apr 12 2021, 4:26 PM
This revision now requires changes to proceed.Apr 12 2021, 4:26 PM
This revision is now accepted and ready to land.Apr 12 2021, 4:33 PM
This revision was automatically updated to reflect the committed changes.