Page MenuHomeElementl

[RFC] rm all legacy_examples
ClosedPublic

Authored by alangenfeld on Apr 9 2021, 10:34 PM.

Details

Summary

These are neglected and out of date. If we want to improve anything that's in here we can pull it out of git history.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 9 2021, 10:59 PM
sashank requested changes to this revision.Apr 10 2021, 6:53 PM

Just to make sure @yuhan gets to take a look at this (she was ooo), just to make sure this doesn't have any affect on docs and the removed examples are tracked

This revision now requires changes to proceed.Apr 10 2021, 6:53 PM

lg2m! thanks for cleaning this up!

@sashank: thanks for tagging. for the context, the only thing that's still in use is the pandas legacy example - i replicated it in docs_snippets/legacy before the docs launch. so i believe nothing on the docs content depends on legacy_examples.

examples/docs_snippets/docs_snippets_tests/intro_tutorial_tests/conftest.py
12

good call - this was where i got stuck when i tried to remove all legacy_example.
imo we probably dont want to depend tutorial code on postgres (it was mentioned in mode section here)

This revision is now accepted and ready to land.Apr 12 2021, 8:53 PM
This revision was automatically updated to reflect the committed changes.