Page MenuHomeElementl

Fix the partition “Run steps” sidebar which required immediate step list

Authored by bengotow on Apr 9 2021, 9:52 PM.
Referenced Files
F2304870: D7379.id35349.diff
Mon, Jul 4, 9:50 AM
Unknown Object (File)
Sun, Jul 3, 11:39 AM
Unknown Object (File)
Sun, Jul 3, 11:32 AM
Unknown Object (File)
Sun, Jul 3, 10:55 AM
Unknown Object (File)
Sat, Jul 2, 6:33 PM
Unknown Object (File)
Fri, Jul 1, 6:33 AM
Unknown Object (File)
Thu, Jun 30, 2:32 PM
Unknown Object (File)
Wed, Jun 29, 5:59 PM



The "Run Steps" sidebar shown beside the graphs on the parititon view was broken (I think) by the changes we made to load the data on the page asynchronously. The component keeps selection in a {stepKey: visible=true/false} dict and the dict was being initialized with no items and not re-initialized when the items loaded.

I think this could be fixed with a useEffect, but I went ahead and split the value into all and hidden, so that "hidden" can start as an empty array and new step keys discovered during loading are shown by default, which I think is a bit cleaner.

Test Plan

Interact with pipeline partitions page

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable