Page MenuHomeElementl

Add MayHaveInstanceWeakref mixin to GrpcServerRegistry
AbandonedPublic

Authored by sashank on Apr 9 2021, 11:25 AM.

Details

Reviewers
dgibson
johann
Summary

The GrpcServerRegistry will now need access to the instance in order to access storages and persist data to them. This diff adds the MayHaveInstanceWeakref mixin to the base GrpcServerRegistry class to support that.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
master
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

sashank published this revision for review.Apr 9 2021, 11:30 AM
dgibson requested changes to this revision.Apr 9 2021, 11:43 AM

This might be better suited for the specific subclass you’re working with that’s already associated with an instance?

This revision now requires changes to proceed.Apr 9 2021, 11:43 AM