Page MenuHomeElementl

Dump dagster debug exports in integration tests
ClosedPublic

Authored by johann on Apr 9 2021, 1:00 AM.

Details

Test Plan

Integration
manually look at bk artifacts

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 9 2021, 1:31 AM
Harbormaster failed remote builds in B28632: Diff 35139!
johann published this revision for review.Apr 9 2021, 1:53 AM
johann added a reviewer: alangenfeld.

@alangenfeld looks like only runs from user deployments have pipeline_snapshot_ids? Does debug export work without grpc servers?

use current test in filename

I think it should be possible to update the test callsites to make sure a snapshot is recorded - likely to be a net improvement to the system depending on where you can enable it.

There might be a path to make the snapshots optional in the debug payload - I think we can still render something in dagit if they are missing. But I would try to get the snapshots first.

to your queue

This revision now requires changes to proceed.Apr 9 2021, 2:45 PM
This revision is now accepted and ready to land.Apr 21 2021, 4:36 PM