Page MenuHomeElementl

[dagit] Remove extra slash on app.py string replace
ClosedPublic

Authored by dish on Apr 8 2021, 8:47 PM.

Details

Summary

The extra slash breaks script/css loading.

Test Plan

yarn build-for-python, then run Dagit. Verify that the app loads. Run with a path prefix, verify same.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish published this revision for review.Apr 8 2021, 8:48 PM
dgibson added a subscriber: dgibson.

should some test have broken that this would fix?

This revision is now accepted and ready to land.Apr 8 2021, 8:50 PM

Some kind of "does the app render at all" smoke test would have been good here. Mostly I'm highly skeptical of smoke tests, but that's the super basic kind that I'm okay with.

This revision was landed with ongoing or failed builds.Apr 8 2021, 8:56 PM
This revision was automatically updated to reflect the committed changes.