Page MenuHomeElementl

[dagit] Break apart Asset materialization query
ClosedPublic

Authored by dish on Apr 8 2021, 7:07 PM.

Details

Summary

When viewing an asset, a single query is performed to retrieve 200 asset materializations. If this is slow, it blocks the entire page from rendering anything useful.

Instead of this, break it into two queries: one to retrieve the latest materialization (limit: 1) and one to retrieve the latest 200. This way, the latest materialization information can be rendered while the rest is still being retrieved.

Test Plan

View an asset, verify that the details and list/graph render properly.

Diff Detail

Repository
R1 dagster
Branch
dish-asset-query
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

dish requested review of this revision.Apr 8 2021, 7:16 PM

This is good.

I'm planning on making some Python/SQL changes to make the details basically a free-query, so it's good to split out the historical query now.

js_modules/dagit/packages/core/src/assets/AssetView.tsx
14–26

remove

This revision is now accepted and ready to land.Apr 8 2021, 8:41 PM
js_modules/dagit/packages/core/src/assets/AssetView.tsx
14–26

Gah, landed before resolving this