Page MenuHomePhabricator

Snowflake library updates
ClosedPublic

Authored by natekupp on Jul 29 2019, 9:22 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Jul 29 2019, 9:22 PM
alangenfeld accepted this revision.Jul 29 2019, 9:34 PM
alangenfeld added inline comments.
python_modules/libraries/dagster-snowflake/dagster_snowflake/resources.py
60

should these logger statments be like '[snowflake] Executing...' or '[dagster-snowflake] Executing...'?

This revision is now accepted and ready to land.Jul 29 2019, 9:34 PM
natekupp added inline comments.Jul 29 2019, 10:31 PM
python_modules/libraries/dagster-snowflake/dagster_snowflake/resources.py
60

yeah I like that idea, updating

This revision was automatically updated to reflect the committed changes.